No pointer events on mobile sidebar when closed #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could actually repro it on the iOS Simulator, but it only occurred when I dragged on the left side of the screen (up to the width of the invisible sidebar). My quick attempt to fix by doing (what I think) was exactly that this PR proposes actually caused weird behavior. I only made a quick visit to this, but I'd suggest we merge this cautiously. |
|
Just confirming that this is still a problem. As seen here: |
|
I should clarify that this PR doesn't seem to resolve the problem, otherwise I'd have merged it. 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SachaG says this should fix #34. I can't repro, so I'm not sure. But at least it doesn't break anything 😊