Add nonscalar parsing #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkirkeby please provide an explanation of this PR. Also please rebase it, your branch is out of date and has conflicts. Conflicts should ideally be solved before code review. |
Lun4m
reviewed
Aug 13, 2024
Comment on lines
-74
to
+119
| let station_id = parse_meta_field(parts.next().ok_or_else(next_err)?, "nationalnr")?; | ||
| let type_id = parse_meta_field(parts.next().ok_or_else(next_err)?, "type")?; | ||
| let message_id = parse_meta_field(parts.next().ok_or_else(next_err)?, "messageid")?; | ||
| let mut header = ObsinnHeader::default(); | ||
| for field in parts.by_ref() { | ||
| if field.starts_with("nationalnr") { | ||
| header.station_id = parse_meta_field(field)?; | ||
| continue; | ||
| } | ||
| if field.starts_with("type") { | ||
| header.type_id = parse_meta_field(field)?; | ||
| continue; | ||
| } | ||
| if field.starts_with("messageid") { | ||
| header.message_id = parse_meta_field(field)?; | ||
| continue; | ||
| } | ||
| if field.starts_with("add") { | ||
| // NOTE: this field has to do with data deletion/update in kvalobs, we do not use it | ||
| header.add = true; | ||
| continue; | ||
| } | ||
| if field.starts_with("received_time") { | ||
| header.received_time = Some(parse_meta_field(field)?); | ||
| continue; | ||
| } | ||
| return Err(Error::Parse(format!( | ||
| "unexpected field in kldata header format: {field}", | ||
| ))); | ||
| } | ||
|
|
||
| if header.station_id == 0 { | ||
| return Err(Error::Parse( | ||
| "missing field `nationalnr` in kldata header".to_string(), | ||
| )); | ||
| } | ||
|
|
||
| // TODO: type_id == 0 is present in stinfosys, so might be a bit dangerous to use here | ||
| if header.type_id == 0 { | ||
| return Err(Error::Parse( | ||
| "missing field `type` in kldata header".to_string(), | ||
| )); | ||
| } |
There was a problem hiding this comment.
I wrote this part, but it shouldn't really be a thing. I need to speak with Søren again, there's no way the fields in the header can come in any order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.