Fix obs climatology #1135
Draft
Fix obs climatology #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ovewh are you still working on this? Would you like some help? It seems like a nice bit of work which could be useful |
|
Yea it would be nice with some help... There where more changes required than I envisioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Rather than having a opaque boolean toggle to enable climatology calculation. Which does not really tell what "climatology" means in pyaerocom. To figure that out you need to look at the const. The changes i suggest it to replace the
keyword obs_use_climatology with a dictionary. Where the start stop, data coverage filters and which "year" the climatology should be set can be specified.
Related issue number
fix #1125
Checklist