Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more detailed descriptions to the mda8 variables. #1320

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

thorbjoernl
Copy link
Collaborator

Change Summary

Adds more detailed descriptions to mda8 variables which references the EU directive. New analyses that makes use of MDA8 calculation will have this new description display in the tool tip on aeroval.

Related issue number

https://github.com/metno/AeroToolsIssues/issues/69

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added the documentation Everything related to code documentation, tutorials and examples label Aug 22, 2024
@thorbjoernl thorbjoernl added this to the m2024-09 milestone Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (9e48af9) to head (8c6cd92).
Report is 38 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1320      +/-   ##
============================================
- Coverage     78.97%   78.97%   -0.01%     
============================================
  Files           136      136              
  Lines         20812    20815       +3     
============================================
+ Hits          16436    16438       +2     
- Misses         4376     4377       +1     
Flag Coverage Δ
unittests 78.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review August 22, 2024 09:41
@heikoklein heikoklein merged commit fb993c6 into main-dev Sep 11, 2024
8 checks passed
@heikoklein heikoklein deleted the mda8-update-description branch September 11, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything related to code documentation, tutorials and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants