Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup to get figures building again #533

Merged
merged 35 commits into from
Feb 10, 2024
Merged

Cleanup to get figures building again #533

merged 35 commits into from
Feb 10, 2024

Conversation

aarmey
Copy link
Member

@aarmey aarmey commented Jan 20, 2024

No description provided.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (4333278) 29.04% compared to head (e655695) 43.25%.
Report is 1 commits behind head on main.

Files Patch % Lines
ddmc/datasets.py 40.42% 56 Missing ⚠️
ddmc/clustering.py 46.91% 43 Missing ⚠️
ddmc/motifs.py 28.57% 20 Missing ⚠️
ddmc/logistic_regression.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #533       +/-   ##
===========================================
+ Coverage   29.04%   43.25%   +14.21%     
===========================================
  Files          12        8        -4     
  Lines        1002      615      -387     
===========================================
- Hits          291      266       -25     
+ Misses        711      349      -362     
Flag Coverage Δ
unittests 43.25% <56.91%> (+14.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armaan-abraham
Copy link
Collaborator

@aarmey

@aarmey
Copy link
Member Author

aarmey commented Feb 5, 2024

@armaan-abraham thanks again for putting this together. I am ~40% through reviewing everything. Could you please take a look at the build errors? It looks like there are a few simple fixes there.

@aarmey aarmey merged commit 123b392 into main Feb 10, 2024
4 checks passed
@aarmey aarmey deleted the fix-code branch February 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants