Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Restore lipsum_from_seed & lipsum_words_from_seed (#98) #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kalkin
Copy link

@kalkin kalkin commented Apr 14, 2023

I introduced the default feature std which enables the rand
package features std & std_rng for the thread_rng() function.
This allows user to use the rand package without adding it with the
right features to own Cargo.toml.

…er#98)

I introduced the default feature `std` which enables the `rand`
package features `std` & `std_rng` for the `thread_rng()` function.
This allows user to use the rand package without adding it with the
right features to own `Cargo.toml`.
@tgross35
Copy link

The feature gate doesn't have to be enabled to use these functions right? It doesn't look like the imports changed at all (but I didn't look too close)

@kalkin
Copy link
Author

kalkin commented Apr 20, 2023

The feature gate doesn't have to be enabled to use these functions right? It doesn't look like the imports changed at all (but I didn't look too close)

Right. The only difference is that the user doesn't need to import rand in to own Cargo.toml. It makes just simpler to use this crate. If you think this is the wrong way to do it, I can remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants