Remove lib2to3
#2311
Open
Remove lib2to3
#2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib2to3is no longer provided with Python 3.13: https://peps.python.org/pep-0594/#deprecated-modules But it's also redundant here.See the following test:
python -c "from setuptestframework import makeadopackage; makeadopackage('test_folder')":Before: with_2_to_3.zip
This PR: plain.zip
The only changes are:
printargumentslib2to3actually breaks annotations by removingfrom __future__ import annotationsdict.items()is redundantly wrapped in alist(probably to avoid issues with single-use iterators)isinstanceis simplified (good catchlib2to3, I've added this source code cleanup to adodbapi: Cleanup obsolete and unsupported python code #2094 )Additionally, I changed
os.mkdirtoos.makedirs(which creates folders recursively) so that you don't have to manually create the test folder first (it would still fail if it already exists)