Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(studio): add more dynamic content to news.article #60

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

mheob
Copy link
Owner

@mheob mheob commented Aug 25, 2024

closes #15

Summary by CodeRabbit

  • New Features

    • Introduced support for new content types in news articles, allowing for simpleBlockContent and blockquote.
    • Added a new blockquote schema for encapsulating quotes and authors.
  • Improvements

    • Streamlined styling options for blockContent, enhancing usability and design consistency.
    • Removed the 'X-Large' option from the spacer field to simplify choices.
  • Bug Fixes

    • Ensured backward compatibility while updating the content structure in news articles.

@mheob mheob added enhancement New feature or request studio Belongs to the Sanity Studio labels Aug 25, 2024
Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsg-irlich-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 3:54pm
tsg-irlich-web-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 3:54pm

Copy link

coderabbitai bot commented Aug 25, 2024

Walkthrough

The changes introduce enhancements to the newsArticle schema by updating the content types to include simpleBlockContent and blockquote, while ensuring backward compatibility. A new schema for blockquote is created, and existing styles for blockContent are streamlined. Additionally, the spacer options have been reduced. These modifications collectively improve the flexibility and organization of the content structure in the application.

Changes

Files Change Summary
apps/studio/schemas/documents/news.article.ts, apps/studio/schemas/index.ts Updated newsArticle schema to include simpleBlockContent and blockquote; new import for blockquote in schema types.
apps/studio/schemas/sections/block-content.ts Reduced available styles for blockContent, simplifying options to "Normal," "H2," "H3," and "Quote."
apps/studio/schemas/sections/blockquote.ts Introduced a new schema for blockquote with fields for quote and author.
apps/studio/schemas/sections/spacer.ts Modified spacer field by removing the 'X-Large' size option.

Assessment against linked issues

Objective Addressed Explanation
Implement content field in news.artikel (#15)
Define title, slug, and author fields (#15)
Implement categories field in news.artikel (#15) Categories field is not defined or addressed.

🐇 In the fields of code, we dance and play,
New quotes to share brighten the day!
With block and spacer, all styled just right,
Our content’s a canvas, a beautiful sight!
Hops of joy for changes, let’s celebrate,
In the garden of code, we cultivate! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Preparing PR description...

Copy link

Preparing review...

Copy link

sonarcloud bot commented Aug 25, 2024

@kodiakhq kodiakhq bot merged commit a1827f3 into main Aug 25, 2024
10 checks passed
@kodiakhq kodiakhq bot deleted the 15-sanity-newsartikel branch August 25, 2024 15:55
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 14675ac and 8b22551.

Files selected for processing (5)
  • apps/studio/schemas/documents/news.article.ts (1 hunks)
  • apps/studio/schemas/index.ts (2 hunks)
  • apps/studio/schemas/sections/block-content.ts (1 hunks)
  • apps/studio/schemas/sections/blockquote.ts (1 hunks)
  • apps/studio/schemas/sections/spacer.ts (1 hunks)
Files skipped from review due to trivial changes (2)
  • apps/studio/schemas/sections/block-content.ts
  • apps/studio/schemas/sections/spacer.ts
Additional comments not posted (3)
apps/studio/schemas/sections/blockquote.ts (1)

1-25: Well-structured blockquote schema definition.

The schema for the blockquote component is well-defined with clear field types and descriptions. The use of an icon for the component enhances user experience by providing a visual cue. The decision to hide the component (hidden: true) might need clarification regarding its usage context.

apps/studio/schemas/documents/news.article.ts (1)

32-38: Enhanced content flexibility in newsArticle schema.

The addition of simpleBlockContent and blockquote to the of property significantly enhances the flexibility and richness of the content structure. This change aligns well with the PR's objectives and maintains backward compatibility.

apps/studio/schemas/index.ts (1)

Line range hint 21-67: Proper integration of blockquote schema into the application.

The addition of the blockquote schema to the schemaTypes array is correctly implemented. This integration allows for the use of the new blockquote component within the application, enhancing content structuring capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request studio Belongs to the Sanity Studio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanity - post news.artikel
1 participant