Fix general PEP8 problems, improve maintainability #67
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
pynytimes/article_search.py
Outdated
| NoneType = type(None) | ||
|
|
||
|
|
||
| def article_search_check_input( |
There was a problem hiding this comment.
Function article_search_check_input has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
pynytimes/article_search.py
Outdated
| return datetime.datetime(input.year, input.month, input.day) | ||
|
|
||
|
|
||
| def article_search_parse_dates( |
There was a problem hiding this comment.
Function article_search_parse_dates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
pynytimes/movie_reviews.py
Outdated
| return datetime.datetime(input.year, input.month, input.day) | ||
|
|
||
|
|
||
| def movie_reviews_check_input( |
There was a problem hiding this comment.
Function movie_reviews_check_input has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
pynytimes/movie_reviews.py
Outdated
| raise TypeError("Critics Pick needs to be a bool") | ||
|
|
||
|
|
||
| def movie_reviews_parse_dates( |
There was a problem hiding this comment.
Function movie_reviews_parse_dates has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
pynytimes/book_reviews.py
Outdated
| NoneType: type = type(None) | ||
|
|
||
|
|
||
| def book_reviews_check_input( |
There was a problem hiding this comment.
Function book_reviews_check_input has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
pynytimes/helpers/article_search.py
Outdated
| NoneType = type(None) | ||
|
|
||
|
|
||
| def article_search_check_input( |
There was a problem hiding this comment.
Function article_search_check_input has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
| return datetime.datetime(input.year, input.month, input.day) | ||
|
|
||
|
|
||
| def article_search_parse_dates( |
There was a problem hiding this comment.
Function article_search_parse_dates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
pynytimes/helpers/movie_reviews.py
Outdated
| return datetime.datetime(input.year, input.month, input.day) | ||
|
|
||
|
|
||
| def movie_reviews_check_input( |
There was a problem hiding this comment.
Function movie_reviews_check_input has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
| raise TypeError("Critics Pick needs to be a bool") | ||
|
|
||
|
|
||
| def movie_reviews_parse_dates( |
There was a problem hiding this comment.
Function movie_reviews_parse_dates has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
| NoneType: type = type(None) | ||
|
|
||
|
|
||
| def book_reviews_check_input( |
There was a problem hiding this comment.
Function book_reviews_check_input has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
No description provided.