Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transaction module #442

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Remove transaction module #442

wants to merge 15 commits into from

Conversation

kevinheavey
Copy link
Collaborator

@kevinheavey kevinheavey commented Jul 5, 2024

The transaaction module is broken (see #268) and solders.transaction works so I guess we should just use that?

This also entails changing the send_transaction methods such that it is the caller's job to fetch a recent blockhash and sign the transaction

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 92.17877% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (7f2f3cb) to head (37b4b75).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   89.77%   89.89%   +0.12%     
==========================================
  Files          28       27       -1     
  Lines        2210     2118      -92     
==========================================
- Hits         1984     1904      -80     
+ Misses        226      214      -12     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant