gradlew.bat/mvnw.bat should NOT be executable #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
seregamorph
commented
Oct 2, 2021
| @@ -60,7 +60,7 @@ public void apply(GeneratorContext generatorContext) { | |||
| generatorContext.addTemplate("gradleWrapperJar", new BinaryTemplate(WRAPPER_JAR, classLoader.getResource(WRAPPER_JAR))); | |||
| generatorContext.addTemplate("gradleWrapperProperties", new URLTemplate(WRAPPER_PROPS, classLoader.getResource(WRAPPER_PROPS))); | |||
| generatorContext.addTemplate("gradleWrapper", new URLTemplate("gradlew", classLoader.getResource("gradle/gradlew"), true)); | |||
| generatorContext.addTemplate("gradleWrapperBat", new URLTemplate("gradlew.bat", classLoader.getResource("gradle/gradlew.bat"), true)); | |||
| generatorContext.addTemplate("gradleWrapperBat", new URLTemplate("gradlew.bat", classLoader.getResource("gradle/gradlew.bat"), false)); | |||
There was a problem hiding this comment.
last argument that is changed to false - executable
seregamorph
changed the title
|
Does this not impact Windows users? They would now have to manually set the file to be executable, correct? |
|
@jameskleeh no, it does not affect Windows users. Windows does not have executable flag in file system.
No, they will not notice anything |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the gradle project is generated, the root directory listing has these gradle-wrapper related files:
The problem is that the second one, the bat file should not be executable, because it is auto-suggested in the shell to be executed, it raises inconvenience and requires manual fixing (via chmod). You can ensure and just list e.g. root directory of micronaut-starter:
The first file for *nix has the executable flag, the second file for Windows - does not.
This PR addresses the issue.
How to check: e.g. run Application in
starter-web-nettymodule, then executecurl "http://localhost:8080/create/DEFAULT/example?build=gradle" -o example.zipand unpack the archive.The same for maven wrapper bat executable.