Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<ranges>: Diagnose the precondition added by LWG-3597 #3731

Merged
merged 7 commits into from
May 30, 2023
Merged

<ranges>: Diagnose the precondition added by LWG-3597 #3731

merged 7 commits into from
May 30, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

And add death test for iota_view.

@frederick-vs-ja
Diagnose the precondition added by LWG-3597
cf9f3ce 
And add death test for `iota_view`.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner May 25, 2023 17:14
@StephanTLavavej StephanTLavavej added enhancement Something can be improved ranges C++20/23 ranges labels May 25, 2023
CaseyCarter
CaseyCarter requested changes May 25, 2023
View reviewed changes
tests/std/tests/P0896R4_views_iota_death/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_iota_death/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_iota_death/env.lst Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej reviewed May 26, 2023
View reviewed changes
stl/inc/ranges Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_iota_death/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_iota_death/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this May 26, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0f29715 into microsoft:main May 30, 2023
@StephanTLavavej
Copy link
Member

Thanks for helping <ranges> users write more correct code! 😻 🎉 🚀

@frederick-vs-ja frederick-vs-ja deleted the iota-death branch May 30, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter