<semaphore>: Add missed mandates for counting_semaphore
#3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change the precondition check for `release` into the form in standard wording. Also make the internal function `_Wait` private.
frederick-vs-ja
changed the title
<sema>Add missed mandates for counting_semaphore<semaphore>: Add missed mandates for counting_semaphore
AlexGuteniev
reviewed
Jun 6, 2023
achabense
reviewed
Jun 7, 2023
StephanTLavavej
added
bug
Also avoid `static_cast`ing `_Update` to `ptrdiff_t` because the type of `_Update` is already `ptrdiff_t`.
StephanTLavavej
approved these changes
Jun 8, 2023
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
strega-nil-ms
approved these changes
Jun 14, 2023
|
Thanks for fixing this bug and improving the STL's detection of misuse! 🐞 🎉 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [thread.sema.cnt]/2.
Also change the precondition check for
releaseinto the form in standard wording ([thread.sema.cnt]/8).Also make the internal function
_Waitprivate.Fixes #3746. Thank you @achabense!