Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups for <future> #3758

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Cleanups for <future> #3758

merged 4 commits into from
Jun 15, 2023

Conversation

achabense
Copy link
Contributor

@achabense achabense commented Jun 10, 2023

_Associated_state::_Ready_at_thread_exit is always-false and has no real effect(#3740). This pr removes all relevant non-functional logics.

_State_manager::_Get_only_once may have similar issues, but I'm not too confident now so it is kept untouched.

@achabense achabense requested a review from a team as a code owner June 10, 2023 03:13
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jun 10, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jun 10, 2023
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@StephanTLavavej StephanTLavavej removed their assignment Jun 10, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jun 14, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 64941ce into microsoft:main Jun 15, 2023
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks for clearing out this dead code! ☠️ 🧹 ✨

@achabense achabense deleted the _For_Future branch June 15, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants