Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary typenames for <format> #3892

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Remove unnecessary typenames for <format> #3892

merged 6 commits into from
Jul 26, 2023

Conversation

achabense
Copy link
Contributor

  • Remove all unnecessary typenames for <format> header (STL: Down with typename? #3718).
  • (Also, move _Is_slash_oper & _Is_slash downstream from <xfilesystem_abi.h> to <filesystem> as it is only needed there.)

@achabense achabense requested a review from a team as a code owner July 20, 2023 18:23
CaseyCarter
CaseyCarter approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor cleanup in pre-existing code, which I'll go ahead and push.

stl/inc/filesystem Outdated Show resolved Hide resolved
@CaseyCarter
Update stl/inc/filesystem
4a2ca9c 
Remove extraneous comment
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Jul 20, 2023
@StephanTLavavej StephanTLavavej added format C++20/23 format filesystem C++17 filesystem labels Jul 20, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 20, 2023
@StephanTLavavej StephanTLavavej removed their assignment Jul 20, 2023
@StephanTLavavej StephanTLavavej mentioned this pull request Jul 20, 2023
Merged
@StephanTLavavej StephanTLavavej self-assigned this Jul 25, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a2979f3 into microsoft:main Jul 26, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for this cleanup and noticing the _Is_slash throughput improvement! 🧹 ✨ 🎉

@achabense achabense deleted the _Format_typename_cleanups branch July 30, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved filesystem C++17 filesystem format C++20/23 format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achabense @StephanTLavavej @CaseyCarter