Consistent iterator type checking for parallel algorithms #3899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Jul 22, 2023
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
requested changes
Jul 26, 2023
CaseyCarter
approved these changes
Jul 26, 2023
|
I've pushed a commit to define |
StephanTLavavej
approved these changes
Jul 26, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
✅ ✔️ ☑️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2985.
Notes:
_REQUIRE_CPP17_MUTABLE_BIDIRECTIONAL_ITERATORand_REQUIRE_CPP17_MUTABLE_RANDOM_ACCESS_ITERATOR, which require mutable iterators to be Cpp17BidirectionalIterator and Cpp17RandomAccessIterator respectively.reverse_copyis specially handled, since it requires the source iterators to be bidirectional.It seems that the checking also make sense for non-parallel (non-
ranges) algorithms, but we can do this in another PR.