Cleanups for <deque> part 1
#4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B. like `insert(where,T&&)`, `insert(where,const&)` should use `emplace`
achabense
force-pushed
the
_Deque_cleanups
branch
from
7d274cd
to
8e18127
Compare
StephanTLavavej
approved these changes
Sep 20, 2023
|
Thanks! The fine-grained commits, combined with VSCode's new ability to identify moved code, made this easy to review. Everything looks good and I didn't find any leftover redundant access specifiers. |
|
Despite the magnitude of the edits, the well-structured fine-grained commits made this very easy to review, and I am confident that we don't need a second maintainer approval. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents of this pr:
trivial relocations XXX: The definition order ofdeque's methods was highly chaotic; reorder them to roughly match with the standard.A&B: some minor cleanups for push/insert functionsC: Let_Construct[_n]do proxy allocation to save some lines.D: The usage of_Allocate_at_least_helperin_Growmapwas problematic, as it can make_Mapsize()not power of 2 if_Allocate_at_least_helperchanges_Newsize; restore to the old version.