Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.9 Preview 1 #4197

Merged
merged 11 commits into from
Nov 17, 2023

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Nov 15, 2023

  • Removed compiler bug workarounds.
    • VSO-1881472 "/clr C++20 x86 System.AccessViolationException with atomic<with_padding_bits<8>>".
    • VSO-1885306 "warning C5039 shouldn't be emitted when an extern "C" function is marked noexcept(false)".
      • I manually verified this fix.
    • DevCom-10138792 VSO-1611566 "Bogus warning C4455: 'operator ""s': literal suffix identifiers that do not start with an underscore are reserved".
      • This bug remains active, but I notified the compiler dev it's assigned to that it appears to be fixed.
    • Remove libcxx skips for std/containers/sequences/vector.bool/move.pass.cpp.
      • We never analyzed this failure, but a compiler bug was fixed, yay!
    • Remove an _MSVC_INTERNAL_TESTING workaround in P0226R1_math_special_functions.
      • This test coverage was enabled for GitHub, and for static linking internally, but was skipped for dynamic linking internally while we waited for the 17.6 Preview 2 redist there. That's ancient history now!
    • EDG common_reference_t started behaving correctly in 17.9 Preview 1, so we can enable VSO_0000000_type_traits test coverage for GitHub.
      • We'll need to skip it internally until EDG is updated there. I'm skipping it, instead of continuing to assert the incorrect behavior, to avoid blocking the EDG update. This blocked MSVC-PR-509221 on 2023-11-06, but I didn't notice until now. 🙀
  • Infrastructure improvements:
    • Updated dependencies.
      • Updated build compiler to VS 2022 17.9 Preview 1 (now required).

Other commits:

  • Update to PowerShell 7.3.9 when building the pool.
  • New pool.
  • README drive-by: Update URL for git clone.
    • I noticed that git emitted a message about another remote moving from username/STL to username/STL.git. While I didn't observe that for my microsoft remote, it still seems better to use the exact URL that GitHub's Code > Clone displays.

x86chk stlimport passed internally, verifying the /clr x86 workaround removal and the _MSVC_INTERNAL_TESTING changes.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Nov 15, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner November 15, 2023 16:36
@StephanTLavavej StephanTLavavej self-assigned this Nov 16, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5abffb6 into microsoft:main Nov 17, 2023
37 checks passed
@StephanTLavavej StephanTLavavej deleted the vs17.9p1 branch November 17, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants