Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P2510R3: Formatting Pointers #4198

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Implement P2510R3: Formatting Pointers #4198

merged 5 commits into from
Jan 11, 2024

Conversation

JMazurkiewicz
Copy link
Contributor

Closes #3799.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner November 15, 2023 17:13
@StephanTLavavej StephanTLavavej added format C++20/23 format cxx26 C++26 feature labels Nov 15, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 15, 2023
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
barcharcraz
barcharcraz previously requested changes Dec 7, 2023
View reviewed changes
stl/inc/format Outdated Show resolved Hide resolved
stl/inc/format Show resolved Hide resolved
@StephanTLavavej StephanTLavavej mentioned this pull request Dec 15, 2023
Merged
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
StephanTLavavej
StephanTLavavej reviewed Jan 11, 2024
View reviewed changes
stl/inc/format Outdated Show resolved Hide resolved
stl/inc/format Outdated Show resolved Hide resolved
tests/std/tests/P2510R3_text_formatting_pointers/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2510R3_text_formatting_pointers/test.cpp Show resolved Hide resolved
tests/std/tests/P2510R3_text_formatting_pointers/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2510R3_text_formatting_pointers/test.cpp Show resolved Hide resolved
tests/std/tests/P2510R3_text_formatting_pointers/test.cpp Show resolved Hide resolved
tests/std/tests/P2510R3_text_formatting_pointers/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Jan 11, 2024
@StephanTLavavej
Copy link
Member

Thanks!! 😻 I pushed a merge with main, resolving the conflict in tests/libcxx/expected_results.txt by enabling the tests for this feature, then I updated comments/messages to address @barcharcraz's feedback, and finally nitpicky feedback of my own.

@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej dismissed barcharcraz’s stale review January 11, 2024 21:49

Feedback has been addressed

@StephanTLavavej StephanTLavavej merged commit c5afe05 into microsoft:main Jan 11, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for implementing this "I can't believe it's not a DR" feature! 😹 😻 😸

@JMazurkiewicz JMazurkiewicz deleted the format/🅱️ointers branch January 13, 2024 13:46
@frederick-vs-ja
Copy link
Contributor

Thanks for bumping __cpp_lib_format to its final value in C++20 mode, which indicates a date later than the "finalization of C++20“ by 38 months!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@barcharcraz barcharcraz barcharcraz left review comments

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx26 C++26 feature format C++20/23 format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2510R3 Formatting Pointers
4 participants
@JMazurkiewicz @StephanTLavavej @frederick-vs-ja @barcharcraz