Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<chrono>: Make format() accept %X and %EX for duration and hh_mm_ss #4250

Merged
merged 1 commit into from
Dec 14, 2023
Merged

<chrono>: Make format() accept %X and %EX for duration and hh_mm_ss #4250

merged 1 commit into from
Dec 14, 2023

Conversation

cpplearner
Copy link
Contributor

Fixes #4247

@cpplearner cpplearner requested a review from a team as a code owner December 8, 2023 03:22
@StephanTLavavej StephanTLavavej added bug Something isn't working format C++20/23 format chrono C++20 chrono labels Dec 8, 2023
@StephanTLavavej
Copy link
Member

Perfect, thank you! 😻 I think this needs only one maintainer approval.

@StephanTLavavej
Copy link
Member

BTW, great catch avoiding the duplication for time_point 🎉

@StephanTLavavej StephanTLavavej self-assigned this Dec 14, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4e9a5cb into microsoft:main Dec 14, 2023
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks for the timely fix! 🕥 😹 🎉

@cpplearner cpplearner deleted the gh-4247-chrono-X branch December 15, 2023 01:35
@StephanTLavavej StephanTLavavej mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working chrono C++20 chrono format C++20/23 format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<chrono>: format() should accept %X and %EX for duration and hh_mm_ss
2 participants
@cpplearner @StephanTLavavej