<numeric>: switch transform_reduce from direct list initialization to copy non-list initialization
#4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM. However, it seems preferred to add a test case to the related test file (tests/std/tests/P0024R2_parallel_algorithms_transform_reduce/test.cpp).
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fsb4000
reviewed
Dec 14, 2023
tests/std/tests/P0024R2_parallel_algorithms_transform_reduce/test.cpp
Outdated
Show resolved
Hide resolved
…est.cpp Co-authored-by: Igor Zhukov <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
tests/std/tests/P0024R2_parallel_algorithms_transform_reduce/test.cpp
Outdated
Show resolved
Hide resolved
…est.cpp Co-authored-by: A. Jiang <[email protected]>
strega-nil-ms
changed the title
<numeric>: switch transform_reduce from direct list initialization to copy non-list initialization
strega-nil-ms
approved these changes
Dec 14, 2023
tests/std/tests/P0024R2_parallel_algorithms_transform_reduce/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0024R2_parallel_algorithms_transform_reduce/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0024R2_parallel_algorithms_transform_reduce/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jan 11, 2024
|
Thanks, this looks great! Apologies for the holiday-induced delay in getting this reviewed. I pushed a commit for minor stylistic issues I noticed. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this bug and congratulations on your first microsoft/STL commit! 🎉 😻 🚀 This is expected to ship in VS 2022 17.10 Preview 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4129.