Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ASAN failures in libcxx #4272

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

StephanTLavavej
Copy link
Member

Followup to #4263.

  • For some MSVC-specific failures, I forgot to mark both :0 (MSVC plain) and :1 (MSVC ASAN).
    • I ran ASAN several times while working on the llvm-project update, but forgot to run it at the very end.
  • Mark x86-specific "AddressSanitizer: allocator is out of memory" issues as :1 SKIPPED.
    • The STL-ASan-CI had to find these, because I was unable to run whole x86 ASAN test runs (they would hang). However, I'm able to reliably reproduce these failures locally by running the individual directories.
  • Comment why 2 tests in mem.poly.allocator.mem are marked for :0 (MSVC) only - it's static analysis warning C6011.
  • Consistently comment when we're marking only :0 (MSVC) because :1 (ASAN) doesn't run static analysis.
  • Enhance a comment to mention that :1 means ASAN.

In the comments, I thought ":0 (MSVC)" and ":1 (ASAN)" were sufficiently clear, but I could say ":0 (MSVC plain)" and ":1 (MSVC ASAN)" to clarify at the cost of some verbosity.

@StephanTLavavej StephanTLavavej added test Related to test code ASan Address Sanitizer labels Dec 16, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner December 16, 2023 22:23
@StephanTLavavej
Copy link
Member Author

/azp run STL-ASan-CI

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@AlexGuteniev

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej changed the title Fix ASAN failures in libcxx Mark ASAN failures in libcxx Dec 18, 2023
@StephanTLavavej

This comment was marked as resolved.

@CaseyCarter
Copy link
Member

/azp run STL-ASan-CI

This wasn't enabled for various reasons, mostly because I hate things that can't be configured in YAML. See #4295.

@StephanTLavavej StephanTLavavej self-assigned this Jan 8, 2024
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 10445f6 into microsoft:main Jan 9, 2024
37 checks passed
@StephanTLavavej StephanTLavavej deleted the asan-followup branch January 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASan Address Sanitizer test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants