Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<type_traits>: Make is_nothrow_convertible a class template and ADL-proof #4318

Merged
merged 3 commits into from
Jan 17, 2024
Merged

<type_traits>: Make is_nothrow_convertible a class template and ADL-proof #4318

merged 3 commits into from
Jan 17, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4317.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner January 15, 2024 01:53
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jan 16, 2024
@StephanTLavavej
Copy link
Member

Thanks for the fix! I really appreciate your remembering the _M_CEE guard too, that saves me quite a bit of headache. 😻

@StephanTLavavej StephanTLavavej self-assigned this Jan 17, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2d18da5 into microsoft:main Jan 17, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for fixing this type trait - I learn something about C++ every day! 🎉 🛠️ ✨

@frederick-vs-ja frederick-vs-ja deleted the is_nothrow_convertible-fix branch January 17, 2024 11:37
@frederick-vs-ja frederick-vs-ja mentioned this pull request Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<type_traits>: some traits are aliases and fail when used with parameter packs
2 participants
@frederick-vs-ja @StephanTLavavej