-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Make the constexpr mutex constructor opt-in (#4000)" #4339
Revert "Make the constexpr mutex constructor opt-in (#4000)" #4339
Conversation
This reverts commit 782dcd5. Fixes microsoft#4338
This is possible now that @amyw-msft merged her MSVC-PR-519388 "Update crt140 nuget package to version 33321 (17.9p2)" today. Thanks for taking care of this @CaseyCarter, it was on my list of things to do today and I didn't know it would take extra effort beyond a plain revert 😻 |
#4000 was me, so I felt obliged to fix the damage I did to the STL =) |
Pushed comment changes! |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for undoing your undo! 🔁 😻 🎉 |
microsoft/STL#3824 microsoft/STL#4000 microsoft/STL#4339 Add escape hatch due to STL change resulting in issues with binary compatibility. https://github.com/microsoft/STL/wiki/Changelog "Fixed bugs: Fixed mutex's constructor to be constexpr. #3824 #4000 #4339 Note: Programs that aren't following the documented restrictions on binary compatibility may encounter null dereferences in mutex machinery. You must follow this rule: When you mix binaries built by different supported versions of the toolset, the Redistributable version must be at least as new as the latest toolset used by any app component. You can define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR as an escape hatch."
STL updates Mutex Fix microsoft/STL#3824 microsoft/STL#4000 microsoft/STL#4339 Add escape hatch due to STL change resulting in issues with binary compatibility. https://github.com/microsoft/STL/wiki/Changelog "Fixed bugs: Fixed mutex's constructor to be constexpr. #3824 #4000 #4339 Note: Programs that aren't following the documented restrictions on binary compatibility may encounter null dereferences in mutex machinery. You must follow this rule: When you mix binaries built by different supported versions of the toolset, the Redistributable version must be at least as new as the latest toolset used by any app component. You can define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR as an escape hatch."**Description**
This reverts commit 782dcd5.
There were some minor merge conflicts (we added
^^^
to the#endif
comment, and ASan changed theenv.lst
file) so this isn't a pure reversion.Fixes #4338