Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yvals_core to February 2024 #4361

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Update yvals_core to February 2024 #4361

merged 1 commit into from
Feb 1, 2024

Conversation

ChaseKnowlden
Copy link
Contributor

Fix #4357

@ChaseKnowlden ChaseKnowlden requested a review from a team as a code owner February 1, 2024 00:33
@StephanTLavavej
Copy link
Member

Thanks! I'll repeat my comment from last time (#4226 (comment)):

I gently suggest tackling slightly larger changes in the future, whether in our repo or others on GitHub, so that other first-time contributors can enjoy the "getting started" experience of fixing a "good first issue" 😸

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Feb 1, 2024
@StephanTLavavej StephanTLavavej self-assigned this Feb 1, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1bc5ca6 into microsoft:main Feb 1, 2024
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks again - this is expected to ship in VS 2022 17.10 Preview 2.

@ChaseKnowlden ChaseKnowlden deleted the yvals2024 branch February 2, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to February 2024
2 participants
@ChaseKnowlden @StephanTLavavej