Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADL-proof implementation of remaining sorting-related algorithms #4367

Merged
merged 15 commits into from
Feb 6, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Feb 3, 2024

Separated from #4004. Towards #140 and #1596.

Partially unblocks one libcxx test (the test still fails with MSVC due to DevCom-10456523):

  • std/algorithms/robust_against_adl.compile.pass.cpp

@StephanTLavavej changed #4362 to avoid conflicting with this PR.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 3, 2024 16:43
@frederick-vs-ja frederick-vs-ja changed the title ADL-proof implementation of remaning sorting-related algorithms ADL-proof implementation of remaining sorting-related algorithms Feb 3, 2024
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Feb 4, 2024
@StephanTLavavej
Copy link
Member

Thanks! 😸 I pushed changes that I'm 98% sure about, please double-check.

@StephanTLavavej StephanTLavavej removed their assignment Feb 5, 2024
@StephanTLavavej StephanTLavavej self-assigned this Feb 5, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've pushed a merge with main to resolve 23 adjacent-edit merge conflicts with #4358 in <algorithm>.

@StephanTLavavej StephanTLavavej merged commit 3688df0 into microsoft:main Feb 6, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

📈 🛡️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants