Toolset update: VS 2022 17.10 Preview 2, WinSDK 22621, CUDA 12.4.0 #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See MSVC-PR-533609.
…t machinery available. NON-GitHub change required: src/vctools/crt/crt-common.settings.targets
…end pointer with nullptr in constexpr", fixed 2023-10-30.
…n to function parameter of a non-movable type is still broken", closed as fixed on 2023-11-06.
…friend function declarations", fixed in 17.10p2.
CaseyCarter
approved these changes
Mar 13, 2024
| @@ -9,12 +9,12 @@ project(msvc_standard_libraries LANGUAGES CXX) | |||
| include(CheckCXXSourceCompiles) | |||
| check_cxx_source_compiles([=[ | |||
| #include <sdkddkver.h> | |||
| static_assert(WDK_NTDDI_VERSION >= NTDDI_WIN10_CO, "Inspecting WDK_NTDDI_VERSION, the Windows SDK version."); | |||
| static_assert(WDK_NTDDI_VERSION >= NTDDI_WIN10_NI, "Inspecting WDK_NTDDI_VERSION, the Windows SDK version."); | |||
There was a problem hiding this comment.
I'm trying really hard not to make a Monty Python reference here for Windows "Ni". (No change requested.)
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Changelog
⚙️ Details
WinSDK
WinSDK 22621 is now used by the MSVC-internal build (this was MSVC-PR-407828 which flowed into
prod/fevia MSVC-PR-528863 on 2024-02-15).In
CMakeLists.txt, this definesNTDDI_VERSION=NTDDI_WIN10_NIto make the latest machinery available, although we don't need any of it yet. #2714 was when we last increased this to the maximum supported value (gettingFILE_DISPOSITION_INFO_EXalong the way). Note: Just because the latest machinery is declared, doesn't mean that we'll start requiring the latest OS - we always have runtime OS checks when attempting to actually use new machinery.CUDA
CUDA 12.4.0 is the first version that allows VS 2022 17.10 (
_MSC_VER1940), allowing us to remove--allow-unsupported-compiler(recently added by #4392). The last time we increased our requirement was #2791 when CUDA 11.6.0 began supporting VS 2022.Note that our escape hatch
_ALLOW_COMPILER_AND_STL_VERSION_MISMATCHremains available if a user can't upgrade their CUDA at the same time as their VS for some reason.AV exclusions
I'm dropping the AV exclusions in
provision-image.ps1. Nobody has hissed at us yet, but I saw MSVC-PR-533609 making similar changes in MSVC-internal scripts, so I think we should do this now (even though our VMs are, of course, completely untrusted, unprivileged, and ephemeral).Compiler bug workaround removals
nullptrinconstexpr", fixed 2023-10-30.NON-GitHub change required to define
NTDDI_VERSIONtoNTDDI_WIN10_NIinsrc/vctools/crt/crt-common.settings.targets.