Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LWG-4016 container-insertable checks do not match what container-inserter does #4539

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4504.

Notes:

  • the call to ranges::for_each in the proposed resolution is "manually inlined" to avoid inclusion dependency;
  • the Standard requires <ranges> to include <concepts>, so the test code doesn't explicitly include it.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 28, 2024 18:50
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels Mar 28, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 28, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6410621 into microsoft:main Apr 9, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

🎉 😸 🚀

@frederick-vs-ja frederick-vs-ja deleted the lwg-4016 branch April 9, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

LWG-4016 container-insertable checks do not match what container-inserter does
2 participants