Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit 'MS extension' deprecation warnings in all Standard modes #4605

Merged

Conversation

StephanTLavavej
Copy link
Member

There are three Microsoft extensions that we've deprecated, with the intent of eventually removing them:

Currently, these deprecations are activated by C++17 mode, but there's no real justification for that. It was practically convenient, because leaving C++14 mode unaffected limited the source-breaking impact on legacy codebases that we immediately had to deal with. However, if we really want to remove this machinery, we need to warn C++14 users. Fortunately, some ecosystem cleanup has already occurred (e.g. Qt stopped using stdext::checked_array_iterator and backported that to their various release branches) since usage of C++17 and later is somewhat popular. Deprecating and removing things always requires effort, but by "fractionating the dose" we can spread out the impact over releases. This is the next step.

This PR changes these MS deprecations to be unconditionally emitted, but still with their fine-grained and coarse-grained _SILENCE_ALL_MS_EXT_DEPRECATION_WARNINGS escape hatches.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Apr 19, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 19, 2024 21:30
@StephanTLavavej StephanTLavavej self-assigned this Apr 26, 2024
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a8d4928 into microsoft:main Apr 26, 2024
39 checks passed
@StephanTLavavej StephanTLavavej deleted the i-have-altered-the-deal branch April 26, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants