-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P3142R0: Printing Blank Lines with println
#4611
P3142R0: Printing Blank Lines with println
#4611
Conversation
Implements https://wg21.link/P3142R0 Applied retroactively as DR, same as stdlibc++ and MS STL: https://github.com/orgs/microsoft/projects/1143?pane=issue&itemId=57457187
@microsoft-github-policy-service agree |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
/azp run STL-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Thanks! 😻 I pushed tiny changes to the product code, and then I figured out how to add test coverage without it hanging. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
….com/H-G-Hristov/STL into hgh/msstl/P3142R0-println-blank-line
@StephanTLavavej I was quite busy and I wasn't able to respond earlier. Basically the idea is to test Thank you! |
I reverted those changes. |
No worries, and thanks for the revert! I've already mirrored this to the MSVC-internal repo (stacked up with 20 other commits), so further changes would have reset that process. If you'd like to add additional test coverage, followup PRs are always welcome after this has merged to Of course, if you discover late-breaking correctness issues, it's always possible to rework or hold back a PR that's already been mirrored, we just like to avoid disrupting the process for "nice to have" changes. |
Thanks again for implementing this feature, which is sure to be used by programmers from beginners to experts everywhere, and congratulations on your first microsoft/STL commit! 😻 🎉 🚀 This is expected to ship in VS 2022 17.11 Preview 2. |
Thank you very much for your support! |
Implements: https://wg21.link/P3142R0 (Fixes GH-4524)
Applied retroactively as DR:
https://github.com/orgs/microsoft/projects/1143?pane=issue&itemId=57457187