Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4507: LWG-4053 Unary call to std::views::repeat does not decay the argument #4685

Merged
merged 3 commits into from
May 23, 2024
Merged

Fix #4507: LWG-4053 Unary call to std::views::repeat does not decay the argument #4685

merged 3 commits into from
May 23, 2024

Conversation

Andor233
Copy link
Contributor

Fix #4507

@Andor233 Andor233 requested a review from a team as a code owner May 22, 2024 08:48
@Andor233 Andor233 changed the title Fix #4507 Fix #4507: LWG-4053 Unary call to std::views::repeat does not decay the argument May 22, 2024
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels May 22, 2024
@StephanTLavavej StephanTLavavej self-assigned this May 22, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ff0cff1 into microsoft:main May 23, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution! 🛠️ 😻 🚀

This change is expected to ship in VS 2022 17.11 Preview 3.

This was referenced May 25, 2024
Open
Open
Open
frederick-vs-ja
frederick-vs-ja reviewed Jun 25, 2024
View reviewed changes
tests/std/tests/P2474R2_views_repeat/test.cpp
{
using RPV = ranges::repeat_view<const char*>;

static_assert(same_as<decltype(views::repeat("foo", unreachable_sentinel)), RPV>);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, these static_assert's actually tested the changes in LWG-4054, not LWG-4053 only. I'll fix this in a new PR soon.

@frederick-vs-ja frederick-vs-ja mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-4053 Unary call to std::views::repeat does not decay the argument
3 participants
@Andor233 @StephanTLavavej @frederick-vs-ja