Toolset update: VS 2022 17.11 Preview 1

[StephanTLavavej]

📜 Changelog

• Infrastructure improvements:
  • Overhauled our Azure Pipelines machinery:
    • Improved the reliability of the submodule checkout task.
    • Improved how clang-format diffs are uploaded and logged.
  • Updated dependencies.
    • Updated build compiler to VS 2022 17.11 Preview 1.

⚙️ Azure Pipelines Commits

Followup to #4594. I manually tested all of the success and failure scenarios for these commits.

• Detect provision-image.ps1 failure.
  • This fixes a major headache in the toolset update process. Previously, if provision-image.ps1 failed while downloading and installing components on the VM, it would stop, but create-1es-hosted-pool.ps1 would keep going on the maintainer's machine, creating a totally doomed pool. When failure occurs, Invoke-AzVMRunCommand doesn't indicate that, so I have a simple strategy - have the VM script print a special message for success, then have the maintainer script search for that message.
  • Use case-sensitive matching for 'PROVISION_IMAGE_SUCCEEDED'.
• Permanently install PowerShell 7.4.2.
  • We'll need this for the following commits.
  • We need to preserve the original filename 'PowerShell-7.4.2-win-x64.msi' instead of generating 'RANDOM.exe', otherwise we won't be able to run it.
  • This means that provision-image.ps1 no longer attempts an "in-place upgrade" of the PowerShell version that's running it. This significantly simplifies the script, and we don't need any PowerShell 7.x features here.
• Download installers to D:\installerTemp.
  • CUDA is 3 GB, so this may be helpful to make the script run faster.
  • On the VM, D: is fast temporary storage.
• Guard against locally running provision-image.ps1.
  • I've never made this mistake, but let's make sure it never happens for any maintainers or contributors. (Obviously, checking for the computer being named 'PROTOTYPE' isn't absolutely perfect, but it's the simplest way to recognize the VM.)
  • This uses a case-sensitive comparison; the default is case-insensitive.
• Skip a blank line emitted by cmd /c ver.
• Set pwsh: true.
  • Needed for the following commit. I'm changing the 'Create Diff' task for consistency.
• Fix Submodule checkout failure should short-circuit checks #4632.
  • PowerShell 7.4 added $PSNativeCommandUseErrorActionPreference: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_preference_variables?view=powershell-7.4#psnativecommanduseerroractionpreference
• Retry submodule checkout up to 4 times.
  • See: https://learn.microsoft.com/en-us/azure/devops/release-notes/2021/pipelines/sprint-195-update#automatic-retries-for-a-task
  • This should essentially fix one of the biggest remaining causes of sporadic PR/CI failure.
  • The release notes said "The failing task is retried immediately" but I now observe quadratic backoff, waiting 1, 4, 9 seconds (which is better than immediate).
• checkout-submodule.yml: Use case-sensitive -creplace and -ceq.
  • git submodule status emits lowercase hexits, and we pass lowercase 'llvm-project'.
  • Although PowerShell defaults to case-insensitive, choosing case-sensitive for string operations should align with C++ expectations and avoid surprises.
• Style: Wrap Restart-AzVM arguments.
• Move Get-AzVM up so we can use $VM.ID earlier.
  • $VM.ID and $VM.StorageProfile.OsDisk.Name are unchanged between these locations.
  • Calling Get-AzVM is necessary; the return value of New-AzVm isn't useful.
• Inline away the Wait-Shutdown function.
  • The progress bar message makes the Write-Host messages unnecessary.
  • -ResourceId $VM.ID is much shorter than -ResourceGroupName $ResourceGroupName -Name $Name, allowing us to directly say 'PowerState/stopped' without wrapping.
  • The original implementation in Add scripts to generate new Virtual Machine Scale Sets and images for build machines #633 (named Start-WaitForShutdown) was verbose, justifying a separate function, but now a direct loop is clearer.
• Consistently use $VM.ID.
• Run sysprep with -ScriptString.
  • $ErrorActionPreference wasn't useful because sysprep is a native command.
  • Write-Host wasn't useful because we aren't printing the message returned by Invoke-AzVMRunCommand.
  • The PowerShell call operator & wasn't useful because we aren't expanding any variables here.
  • In addition to being slightly simpler, this avoids having a script file that someone might try to run.
• Style: For New-AzVMConfig, use -VMName instead of the alias -Name.
  • See: https://learn.microsoft.com/en-us/powershell/module/az.compute/new-azvmconfig?view=azps-12.0.0#-vmname
• New-AzVm defaults to Trusted Launch as of Azure PowerShell 11.0.0 (November 2023).
  • See: https://techcommunity.microsoft.com/t5/azure-compute-blog/breaking-change-for-vm-amp-vmss-powershell-cli-customers/ba-p/3937037
  • See: https://learn.microsoft.com/en-us/powershell/azure/release-notes-azureps?view=azps-12.0.0#azcompute-700
• Give validationBuildOutputLocation a dedicated name, and clean it.
• Inline create-prdiff.ps1, part 1.
  • No changes except for:
    • Drop redundant banner.
    • $DiffFile was never passed as an argument, so set it as an ordinary variable.
    • Indentation.
• Inline create-prdiff.ps1, part 2.
  • Simplify by using the PowerShell redirection operator > instead of Start-Process.
  • https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_redirection?view=powershell-7.4#powershell-redirection-operators
  • Verified that the diff can be applied cleanly.
• Inline create-prdiff.ps1, part 3.
  • Overhaul messaging.
• Inline create-prdiff.ps1, part 4.
  • Actually name the file format.diff before uploading, as this appears in the zip.
• Inline create-prdiff.ps1, part 5.
  • Name the zip differently from the file within.
• Inline create-prdiff.ps1, part 6.
  • Style: Avoid Yoda condition when checking git diff output.
• Improve provision-image.ps1's synopsis/description.
  • They were talking about our old scale set system. Now they talk about hosted pools, and explain the overall process in more detail.

🧰 Toolset Update Commits

• Require Node.js 22.2.0.
• New pool.
• VS 2022 17.11 Preview 1.
  • Not yet required - the internal toolset is still 19.40.
• Remove compiler warning suppressions.
  • MSVC no longer emits warning C4521 'multiple copy constructors specified', since at least MSVC-PR-368907 on 2021-12-09.
• Work around VSO-2064546 "EDG ICE when deriving from std::num_get".

STL-ASan-CI passed.

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.