Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use requires-clauses for pair and tuple since C++20 #4819

Merged

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jul 7, 2024

Towards #602. Also unconditionally uses is_swappable<T>::value workaround for expected as suggested in #4658 (comment).

Notes:

  • some occurences of conjunction_v are preserved for tuple because fold expressions are not yet decomposed for associated constraints until C++26 (and thus doesn't short-circuit, see WG21-P2963R2);
  • changes for tuple constructors were attempted but are currently given up due to LLVM-59827.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner July 7, 2024 23:17
@frederick-vs-ja frederick-vs-ja marked this pull request as draft July 7, 2024 23:43
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jul 8, 2024
@frederick-vs-ja frederick-vs-ja marked this pull request as ready for review July 8, 2024 17:47
@StephanTLavavej StephanTLavavej self-assigned this Jul 9, 2024
@StephanTLavavej StephanTLavavej removed their assignment Jul 10, 2024
@StephanTLavavej StephanTLavavej self-assigned this Jul 10, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ecbc1ef into microsoft:main Jul 11, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

  • Concepts 📈
  • SFINAE 📉
  • Happy kitty 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants