Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apps initialized with a storyboard don't get a main window #1836

Closed
bviglietta opened this issue Jan 26, 2017 · 0 comments
Closed

Apps initialized with a storyboard don't get a main window #1836

bviglietta opened this issue Jan 26, 2017 · 0 comments
Assignees
@jaredhms
Labels
Area-User Experience Priority-Normal Task
Milestone
1704

Comments

@bviglietta
Copy link
Contributor

Applications that are initialized with a storyboard are supposed to have a main UIWindow automatically created, and the app delegate's "window" property should be initialized with this value. However, this window is never created in WinObjC apps.

The only window that gets created is the popup window, which is also, as a result of being the only window in existence, erroneously marked as the key window.

See the XAMLCatalog sample app for an example of this behavior.
@tadam-msft tadam-msft modified the milestone: Backlog Mar 21, 2017
@tadam-msft tadam-msft assigned jaredhms and unassigned tadam-msft Mar 30, 2017
@tadam-msft tadam-msft modified the milestones: 1704, Backlog Mar 30, 2017
jaredhms added a commit to jaredhms/WinObjC that referenced this issue Apr 6, 2017
@jaredhms
Cleaning up UIWindow initialization and usage
da800d3 
- Non storyboard apps are expected to create their own UIWindow and makeKeyAndVisible
- Storyboard apps get a UIWindow that they need to makeKeyAndVisible
- Fixing up annotations on UIWindow and UIApplication
- Removed a lot of dead code from UIApplication, including two UIWindows that we don't need/use.
- Switched UIWindow.mm and UIApplication.mm to ARC

Fixes microsoft#1836: Apps initialized with a storyboard don't get a main window (they get the 'popup window').
@jaredhms jaredhms mentioned this issue Apr 7, 2017
Merged
jaredhms added a commit to jaredhms/WinObjC that referenced this issue Apr 13, 2017
@jaredhms
Cleaning up UIWindow initialization and usage
bc23816 
- Non storyboard apps are expected to create their own UIWindow and makeKeyAndVisible
- Storyboard apps get a UIWindow that they need to makeKeyAndVisible
- Fixing up annotations on UIWindow and UIApplication
- Removed a lot of dead code from UIApplication, including two UIWindows that we don't need/use.
- Switched UIWindow.mm and UIApplication.mm to ARC

Fixes microsoft#1836: Apps initialized with a storyboard don't get a main window (they get the 'popup window').
jaredhms added a commit to jaredhms/WinObjC that referenced this issue Apr 14, 2017
@jaredhms
Cleaning up UIWindow initialization and usage
509ec02 
- Non storyboard apps are expected to create their own UIWindow and makeKeyAndVisible
- Storyboard apps get a UIWindow that they need to makeKeyAndVisible
- Fixing up annotations on UIWindow and UIApplication
- Removed a lot of dead code from UIApplication, including two UIWindows that we don't need/use.
- Switched UIWindow.mm and UIApplication.mm to ARC

Fixes microsoft#1836: Apps initialized with a storyboard don't get a main window (they get the 'popup window').
jaredhms added a commit that referenced this issue Apr 14, 2017
@jaredhms
Cleaning up UIWindow initialization and usage (#2445)
dcded83 
* Cleaning up UIWindow initialization and usage

- Non storyboard apps are expected to create their own UIWindow and makeKeyAndVisible
- Storyboard apps get a UIWindow that they need to makeKeyAndVisible
- Fixing up annotations on UIWindow and UIApplication
- Removed a lot of dead code from UIApplication, including two UIWindows that we don't need/use.
- Switched UIWindow.mm and UIApplication.mm to ARC

Fixes #1836: Apps initialized with a storyboard don't get a main window (they get the 'popup window').

* s

* Fixing up annotations; using NOTINPLAN_* macros to headers where applicable.

* Added functional tests for UIApplicationDelegate.  Also cleaning up a bit more of the app launch path.

* Removing accidentally-added file.

* Incorporating CR feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredhms jaredhms

Labels
Area-User Experience Priority-Normal Task
Projects
None yet
Milestone
1704
Development

No branches or pull requests
4 participants
@bviglietta @jaredhms @ArnOmsft @tadam-msft