Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CGColor independent of UIColor #2243

Closed
3 tasks done
msft-Jeyaram opened this issue Mar 15, 2017 · 0 comments · Fixed by #2538
Closed
3 tasks done

Implement CGColor independent of UIColor #2243

msft-Jeyaram opened this issue Mar 15, 2017 · 0 comments · Fixed by #2538
Assignees
@msft-Jeyaram
Labels
Area-Foundation SubArea-CoreGraphics Task
Milestone
1704

Comments

@msft-Jeyaram
Copy link
Contributor

msft-Jeyaram commented Mar 15, 2017 •
edited
Loading

As of now, CGColor is pretty much an instance of UIColor.

  • Implement CGColor as an independent entity

  • Implement UIColor interms of CGColor

  • CoreGraphics.UnitTests dependency on UIKit should be removed.
@msft-Jeyaram msft-Jeyaram changed the title Implement CGColor (without depending on UIColor) Implement CGColor independent of UIColor Mar 15, 2017
@rajsesh rajsesh added this to the 1704 milestone Mar 20, 2017
msft-Jeyaram added a commit to msft-Jeyaram/WinObjC that referenced this issue Apr 17, 2017
@msft-Jeyaram
Implement CGColor independent of UIColor
d7e5a95 
- Removal of BrushTypes
- Overall code improvements
- Support for grayscale

fixes microsoft#2243
@msft-Jeyaram msft-Jeyaram mentioned this issue Apr 17, 2017
Merged
7 tasks
msft-Jeyaram added a commit to msft-Jeyaram/WinObjC that referenced this issue Apr 27, 2017
@msft-Jeyaram
Implementation of CGColor
eaa8831 
- Implement CGColor backed by RGBA values
     - This would support Grayscale by only using a {gray,gray,gray,alpha} value vs {r,g,b,a}
- Support RGBA and Grayscale colorspace
- Implement via runtime base
- Implement CGColorGetPattern
- Removed Lazy loading of UIColor
- Removed dependency on UIColor
- Properly implemented CGColorEqualToColor
Fixes microsoft#2243
msft-Jeyaram added a commit to msft-Jeyaram/WinObjC that referenced this issue Apr 27, 2017
@msft-Jeyaram
Implement UIColor via class clustering and CGColor
abec632 
- Implement UIColor as a class cluster
- Support singleton const color
- Support for getRed&getWhite Apis to respect colorspace
- Removed direct access of internal structs
- Removed unnecessary functionality
- Improve Code quality

Fixes microsoft#2524, microsoft#2243
msft-Jeyaram added a commit to msft-Jeyaram/WinObjC that referenced this issue Apr 27, 2017
@msft-Jeyaram
Implement UIColor via class clustering and CGColor
2577d39 
- Implement UIColor as a class cluster
- Support singleton const color
- Support for getRed&getWhite Apis to respect colorspace
- Removed direct access of internal structs
- Removed unnecessary functionality
- Improve Code quality

Fixes microsoft#2524, microsoft#2243
msft-Jeyaram added a commit that referenced this issue Apr 27, 2017
@msft-Jeyaram
Implementation of CGColor
cde5ac1 
- Implement CGColor backed by RGBA values
     - This would support Grayscale by only using a {gray,gray,gray,alpha} value vs {r,g,b,a}
- Support RGBA and Grayscale colorspace
- Implement via runtime base
- Implement CGColorGetPattern
- Removed Lazy loading of UIColor
- Removed dependency on UIColor
- Properly implemented CGColorEqualToColor
Fixes #2243
msft-Jeyaram added a commit that referenced this issue Apr 27, 2017
@msft-Jeyaram
Implement UIColor via class clustering and CGColor
f6f84fa 
- Implement UIColor as a class cluster
- Support singleton const color
- Support for getRed&getWhite Apis to respect colorspace
- Removed direct access of internal structs
- Removed unnecessary functionality
- Improve Code quality

Fixes #2524, #2243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msft-Jeyaram msft-Jeyaram

Labels
Area-Foundation SubArea-CoreGraphics Task
Projects
None yet
Milestone
1704
Development

Successfully merging a pull request may close this issue.

Implement CGColor independent of UIColor msft-Jeyaram/WinObjC
2 participants
@rajsesh @msft-Jeyaram