Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete NSFileHandle stubs #2367

Closed
rajsesh opened this issue Mar 29, 2017 · 2 comments · Fixed by #2477
Closed

Complete NSFileHandle stubs #2367

rajsesh opened this issue Mar 29, 2017 · 2 comments · Fixed by #2477
Assignees
@DHowett-MSFT
Labels
Area-Foundation Task
Milestone
1704

Comments

@rajsesh
Copy link
Contributor

rajsesh commented Mar 29, 2017

initWithCoder:
encodeWithCoder:
fileHandleWithStandardOutput
fileHandleWithStandardError
readInBackgroundAndNotify

Also:
NSFileHandleReadCompletionNotification
@rajsesh rajsesh added this to the 1705 milestone Mar 29, 2017
@DHowett-MSFT
Copy link

DHowett-MSFT commented Mar 30, 2017 •
edited
Loading

I wonder how one encodes a file handle; it's a pointer to an ephemeral thing. 😕

@DHowett-MSFT
Copy link

By way of answering my own question: they cannot be coded. Attempts to do so throw an exception unless an NSXPCCoder is used.

Since we do not support Mach IPC, we will just implement them to throw exceptions.

@rajsesh rajsesh modified the milestones: 1704, 1705 Apr 4, 2017
DHowett-MSFT pushed a commit to DHowett-MSFT/WinObjC that referenced this issue Apr 10, 2017
@DHowett
Re-annotate most of NSFileHandle to NotInPlan
71a989a 
Fixes microsoft#2367.
DHowett-MSFT pushed a commit to DHowett-MSFT/WinObjC that referenced this issue Apr 10, 2017
@DHowett
Finish NSFileHandle's stubbed methods
8701ee7 
This commit marks roughly half of NSFileHandle's APIs NotInPlan.
WinSock deals in opaque handles which cannot be used with
open/close/seek/tell/read/write, so most of NSFileHandle's APIs cannot
be supported with the POSIX File Descriptor interface.

The background APIs are better suited to use with a socket than with a
file, so until somebody asks for socket support, we will mark them
unplanned.

File handles cannot be coded except through IPC coders, but WinObjC does
not have any IPC coders.

Fixes microsoft#2367.
@DHowett-MSFT DHowett-MSFT mentioned this issue Apr 10, 2017
Merged
DHowett-MSFT pushed a commit that referenced this issue Apr 11, 2017
@DHowett
Finish NSFileHandle's stubbed methods (#2477)
4c0ff52 
This commit marks roughly half of NSFileHandle's APIs NotInPlan.
WinSock deals in opaque handles which cannot be used with
open/close/seek/tell/read/write, so most of NSFileHandle's APIs cannot
be supported with the POSIX File Descriptor interface.

The background APIs are better suited to use with a socket than with a
file, so until somebody asks for socket support, we will mark them
unplanned.

File handles cannot be coded except through IPC coders, but WinObjC does
not have any IPC coders.

Fixes #2367.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-Foundation Task
Projects
None yet
Milestone
1704
Development

Successfully merging a pull request may close this issue.

Finish NSFileHandle's stubbed methods DHowett-MSFT/WinObjC
2 participants
@DHowett-MSFT @rajsesh