Implement RTObjCInterop to be consumed via built packages #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… source the code. - Fixing various issues with packaging - Open sourcing the code - This removed the old way of copying binaries around, from now one we will generate it directly from the source code. Fixes microsoft#2737, microsoft#2746
msft-Jeyaram
changed the title
|
Will force push the diffs to make it easier to review. |
aballway
approved these changes
May 31, 2017
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ClangCompile Include="dllmain.cpp" /> | ||
| <ClangCompile Include="src/*.mm" /> |
There was a problem hiding this comment.
why is this repeated so many times?
There was a problem hiding this comment.
which one? codeflow isn't being nice here
There was a problem hiding this comment.
<ClangCompile Include="src/*.mm" />
There was a problem hiding this comment.
LOL inherited;P can fix that up
rajsesh
suggested changes
Jun 1, 2017
| @implementation RTObject | ||
| + (instancetype)alloc { | ||
| NSLog(@"Cannot allocate WinRT components through alloc/new! Use static instantiators.", NSStringFromClass(self)); | ||
| assert(0); |
There was a problem hiding this comment.
as are rule, we aren't using asserts/nslog in the framework. Throwing exception instead may be appropriate here.
| <UpdateAssemblyInfo>false</UpdateAssemblyInfo> | ||
| <WriteVersionInfoToBuildLog>false</WriteVersionInfoToBuildLog> | ||
| <TargetFramework>uap10.0</TargetFramework> | ||
| </PropertyGroup> |
DHowett-MSFT
approved these changes
Jun 1, 2017
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ClangCompile Include="dllmain.cpp" /> | ||
| <ClangCompile Include="src/*.mm" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2737, #2746
This change is