-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VSIX to work with Dev17 #936
Conversation
To run it from dev17 doesn't it also require an update to the Single-project MSIX Packaging Tools extension? Only using the ProjectReunion extension will result in a debug target error. |
@Fabi could you elaborate on how you got the error you're referring to? I haven't seen it yet. I tested this workflow successfully:
I'm not what I would consider a VSIX expert, so if you have some insights I'll gladly listen. :) |
@DefaultRyan The error @Fabi was referring to only occurs if you copy the MSIX manifest and assets out of the wapproj into the application project, add |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@wjk do you know if this option works for C++ projects? |
@sylveon I see no reason why it wouldn’t, although the IDE integration might be a bit screwy, since I don’t know if the VS bits have been tested with vcxproj as well as with csproj.
|
This change updates the VSIX to target the next version of VS. Fortunately, this VSIX contains only templates and no code, so it can target both Dev16 and Dev17 fairly easily.
This change updates the VSIX to target the next version of VS. Fortunately, this VSIX contains only templates and no code, so it can target both Dev16 and Dev17 fairly easily.
The prerequisite on
Microsoft.VisualStudio.Component.CoreEditor
was causing issues in Dev17, so I removed it. The other two prerequisites I simply extended the version range.I tested installing it into a private build of Dev17, and verified: