Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VSIX to work with Dev17 #936

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Conversation

DefaultRyan
Copy link
Member

This change updates the VSIX to target the next version of VS. Fortunately, this VSIX contains only templates and no code, so it can target both Dev16 and Dev17 fairly easily.

The prerequisite on Microsoft.VisualStudio.Component.CoreEditor was causing issues in Dev17, so I removed it. The other two prerequisites I simply extended the version range.

I tested installing it into a private build of Dev17, and verified:

  • Project and item templates still function as expected.
  • Was able to create a new WinUI3 project, build, and run it successfully.

@Fabi
Copy link

Fabi commented Jun 17, 2021

To run it from dev17 doesn't it also require an update to the Single-project MSIX Packaging Tools extension? Only using the ProjectReunion extension will result in a debug target error.

@DefaultRyan
Copy link
Member Author

To run it from dev17 doesn't it also require an update to the Single-project MSIX Packaging Tools extension? Only using the ProjectReunion extension will result in a debug target error.

@Fabi could you elaborate on how you got the error you're referring to? I haven't seen it yet.

I tested this workflow successfully:

  • Install this updated VSIX into Dev17
  • Create a new project, using template "Blank App, Packaged with WAP (WinUI 3 in Desktop)
  • Build project, and run with F5

I'm not what I would consider a VSIX expert, so if you have some insights I'll gladly listen. :)

@wjk
Copy link

wjk commented Jun 24, 2021

@DefaultRyan The error @Fabi was referring to only occurs if you copy the MSIX manifest and assets out of the wapproj into the application project, add <EnablePreviewMsixTooling>true</EnablePreviewMsixTooling> to the csproj file, and then try to run the csproj. While this isn’t the default MSIX packaging behavior (yet!), it is far superior to using wapproj.

@DefaultRyan
Copy link
Member Author

@Fabi and @wjk thanks. Somebody on our end is already aware of this and has the work scheduled. It's just out of scope for this particular PR.

@DefaultRyan
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DefaultRyan DefaultRyan merged commit 80155b9 into main Jun 28, 2021
@DefaultRyan DefaultRyan deleted the user/defaultryan/vsix_dev17 branch June 28, 2021 20:38
@DefaultRyan DefaultRyan linked an issue Jun 28, 2021 that may be closed by this pull request
@sylveon
Copy link

sylveon commented Jul 1, 2021

@wjk do you know if this option works for C++ projects?

@wjk
Copy link

wjk commented Jul 1, 2021

@sylveon I see no reason why it wouldn’t, although the IDE integration might be a bit screwy, since I don’t know if the VS bits have been tested with vcxproj as well as with csproj.

Microsoft.ProjectReunion.WinUI.nupkg contains props/targets that enable use in C++ projects. Inspection reveals that these targets include Microsoft.Build.Msix.targets if EnableMsixPreviewTooling is set to true; there is even a bit of C++-specific MSIX glue. Hope this helps!

DefaultRyan added a commit that referenced this pull request Jul 14, 2021
This change updates the VSIX to target the next version of VS. Fortunately, this VSIX contains only templates and no code, so it can target both Dev16 and Dev17 fairly easily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Studio 2022 Support
6 participants