Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable linux electron build #1457

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Disable linux electron build #1457

merged 1 commit into from
Oct 14, 2019

Conversation

karanbirsingh
Copy link
Contributor

Description of changes

The linux electron-distributable step in CI is failing because of electron-userland/electron-builder#4318. This PR temporarily disables the Linux build.

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh karanbirsingh requested a review from a team as a code owner October 14, 2019 20:29
@karanbirsingh karanbirsingh merged commit 639b035 into microsoft:master Oct 14, 2019
@karanbirsingh karanbirsingh deleted the linux branch October 14, 2019 20:59
@Shobhit1 Shobhit1 mentioned this pull request Oct 14, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shobhit1 Shobhit1 Shobhit1 approved these changes

@devaradhanm devaradhanm devaradhanm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanbirsingh @Shobhit1 @devaradhanm