Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(target-size-automation): adding target size to the needs-review rules #7330

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JGibson2019
Copy link
Contributor

Details

Adding target-size to the needs review rules. This is the pre-PR for Madalyn's PR that enables target-size in assessment and provides the initial visualization and support for the test step

Motivation
Context

The enablement of target-size for general assessment

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@JGibson2019 JGibson2019 requested a review from a team as a code owner May 9, 2024 19:56
@JGibson2019 JGibson2019 added the pr: DO NOT MERGE Dont merge this PR. label May 10, 2024
@JGibson2019
Copy link
Contributor Author

will update with final wording for the needs review cards and the update the final e2e test. do not review or merge until those are added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: DO NOT MERGE Dont merge this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant