Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs/gallery card component #1445

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

namanbarkiya
Copy link
Contributor

@namanbarkiya namanbarkiya commented Jan 29, 2024

Why are these changes needed?

The gallery features incredibly valuable community contributions, however it doesn't seem like the component in the current docs/gallery card is optimized:

image

So updated the component to make it look better and more engaging:

image

Let me know if any changes can be done to this to make it better.
I have continued the design approach by using the antd for typography.

Related issue number

Checks

@namanbarkiya
Copy link
Contributor Author

namanbarkiya commented Jan 29, 2024

@microsoft-github-policy-service agree

@cheng-tan
Copy link
Contributor

PR looks good, but I think the card looks better with a border on light theme

@namanbarkiya
Copy link
Contributor Author

namanbarkiya commented Jan 29, 2024

Previously border was getting merged with the image, just adding a small padding to image and making the border property true gave this output:

image

Should I push this one? @cheng-tan

@cheng-tan
Copy link
Contributor

Previously border was getting merged with the image, just adding a small padding to image and making the border property true gave this output:

image

Should I push this one? @cheng-tan

yep, I think this is better for light theme

@namanbarkiya
Copy link
Contributor Author

Done adding the changes @cheng-tan

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cf5bb0) 33.19% compared to head (e7d5a0b) 33.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1445   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files          41       41           
  Lines        4950     4950           
  Branches     1135     1135           
=======================================
  Hits         1643     1643           
  Misses       3177     3177           
  Partials      130      130           
Flag Coverage Δ
unittests 33.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Jan 29, 2024
@victordibia
Copy link
Collaborator

Thanks all!

Merged via the queue into microsoft:main with commit 3608079 Jan 29, 2024
19 checks passed
corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
* Improve docs/gallery card component

* added border to gallery card component
@namanbarkiya
Copy link
Contributor Author

Thanks for the merge!
@cheng-tan I am also thinking about adding a dark mode to cards, right now they are white in dark mode. Any suggestions?

@ekzhu
Copy link
Collaborator

ekzhu commented Jan 30, 2024

@jackgerrits sorry to spam unassigned

@ekzhu ekzhu removed the request for review from jackgerrits January 30, 2024 19:05
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Improve docs/gallery card component

* added border to gallery card component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants