fix: Exclude the win32 IP address control from the SiblingUniqueAndFocusable rule #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
reviewed
Jul 23, 2024
codeofdusk
force-pushed
the
sibling-unique-exclude-ip
branch
from
8503144
to
c88f0d8
Compare
# This is the 1st commit message: Exclude the win32 IP address control from the SiblingUniqueAndFocusable rule (false positive) # The commit message microsoft#2 will be skipped: # Update build pipeline for testing # The commit message microsoft#3 will be skipped: # Revert "Update build pipeline for testing" # The build unexpectedly passed. Was this a flakey test? # # This reverts commit 89943c0.
codeofdusk
force-pushed
the
sibling-unique-exclude-ip
branch
from
c88f0d8
to
6d94e3d
Compare
JGibson2019
approved these changes
Aug 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The Win32 IP address control consists of a pane of edit fields, one per octet of an IPV4 address. As such, the
SiblingUniqueAndFocusablerule is not appropriate for this control.Pull request checklist