Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use record instead of class for LSP types. #258

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Use record instead of class for LSP types. #258

merged 1 commit into from
Jul 20, 2023

Conversation

karthiknadig
Copy link
Member

Fixes #253

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Jul 20, 2023
@karthiknadig karthiknadig self-assigned this Jul 20, 2023
@karthiknadig karthiknadig marked this pull request as ready for review July 20, 2023 00:18
@karthiknadig karthiknadig enabled auto-merge (squash) July 20, 2023 00:19
@karthiknadig karthiknadig merged commit 0512a11 into microsoft:main Jul 20, 2023
35 checks passed
@karthiknadig karthiknadig deleted the use-record1 branch August 4, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use record for types that are converted to and from JSON
2 participants
@karthiknadig @roblourens