Prevent line ending conversion in repos #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in the following mu_basecore Windows agent pipeline runs: |
apop5
approved these changes
Apr 12, 2024
os-d
approved these changes
Apr 12, 2024
|
On hold to let this PR verify there's no unexpected impact before rolling out to other repos. |
No negative consequences seen from that PR, so I'm going to merge this PR now. |
Unsets the text attribute on all files to prevent their line endings from being normalized. See https://git-scm.com/docs/gitattributes for background. This was previously accomplished solely by instructing users to set core.autocrlf to false. However, that does not trasnlate to pipelines and setting in a pipeline requires the system level git configuration to be modified prior to checkout. Git configs cannot be checked into to a repo and automatically used for security reasons. This is a simple way to check the change into the repo so it applies for all users including pipelines to prevent line ending conversion. This allows plugins like LineEndingCheck to produce similar results in pipelines on Linux and Windows agents. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
add_gitattr_no_text_le_conversion
branch
from
fa373f1
to
3d937ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsets the text attribute on all files to prevent their line endings
from being normalized.
See https://git-scm.com/docs/gitattributes for background.
This was previously accomplished solely by instructing users to set
core.autocrlf to false. However, that does not translate to pipelines
and setting in a pipeline requires the system level git configuration
to be modified prior to checkout. Git configs cannot be checked into
to a repo and automatically used for security reasons.
This is a simple way to check the change into the repo so it applies
for all users including pipelines to prevent line ending conversion.
This allows plugins like LineEndingCheck to produce similar results
in pipelines on Linux and Windows agents.