Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -a flag on stuart_build commands #343

Merged
merged 3 commits into from
May 28, 2024

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented May 24, 2024

-a is not a first class parameter for stuart_build, so mu_devops should not expect that it exists. If a platform has added a necessary -a argument, then they can pass it to the command in mu_devops through the build_flags for BuildPlatform.yml or extra_build_args for PrGate.yml

Integration

Any consumers of PlatformBuild.yml should remove the build_arch parameter. If it still needs to be passed, add the -a <arch> flag to the build_flags parameter.

@Javagedes Javagedes added the impact:breaking-change Requires integration attention label May 28, 2024
@Javagedes Javagedes self-assigned this May 28, 2024
@Javagedes Javagedes merged commit 467a1ca into main May 28, 2024
2 checks passed
@Javagedes Javagedes deleted the personal/joeyvagedes/remove-flag-requirement branch May 28, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:breaking-change Requires integration attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants