Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure exporter creates valid python name for opset vars #1051
Ensure exporter creates valid python name for opset vars #1051
Changes from 5 commits
0b76a64
7dd1186
5aa4f6a
706b5fd
30efcf6
4a6a399
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 227 in onnxscript/backend/onnx_export.py
Codecov / codecov/patch
onnxscript/backend/onnx_export.py#L227
Check warning on line 229 in onnxscript/backend/onnx_export.py
Codecov / codecov/patch
onnxscript/backend/onnx_export.py#L229
Check warning on line 456 in onnxscript/backend/onnx_export.py
Codecov / codecov/patch
onnxscript/backend/onnx_export.py#L456
Check warning on line 164 in onnxscript/backend/onnx_export_test.py
Codecov / codecov/patch
onnxscript/backend/onnx_export_test.py#L164