Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traceable from _aten_scaled_dot_product_efficient_attention_fillin_empty_outputs #1585

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

justinchuby
Copy link
Collaborator

Fix _aten_scaled_dot_product_efficient_attention_fillin_empty_outputs regression

…illin_empty_outputs`

Fix _aten_scaled_dot_product_efficient_attention_fillin_empty_outputs regression
@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.62%. Comparing base (d39ff45) to head (ef19517).

Current head ef19517 differs from pull request most recent head 505367b

Please upload reports for the commit 505367b to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1585   +/-   ##
=======================================
  Coverage   77.61%   77.62%           
=======================================
  Files         219      219           
  Lines       23455    23455           
  Branches     4049     4049           
=======================================
+ Hits        18204    18206    +2     
+ Misses       4460     4459    -1     
+ Partials      791      790    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titaiwangms
Copy link
Contributor

Do we want an issue for fix getitem in tensor.py?

@justinchuby
Copy link
Collaborator Author

Done #1586

@justinchuby justinchuby merged commit 1efd8e6 into main Jun 3, 2024
6 checks passed
@justinchuby justinchuby deleted the justinchuby-patch-1 branch June 3, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants