Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torchlib] Implement aten::type_as #1726

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[torchlib] Implement aten::type_as #1726

merged 1 commit into from
Jul 9, 2024

Conversation

justinchuby
Copy link
Collaborator

No description provided.

@justinchuby justinchuby added topic: torch_lib Related to the torch/aten function lib in development merge at lgtm Reviewers can merge when they approve labels Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.92%. Comparing base (60f2d2c) to head (8537dee).

Files Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (60f2d2c) and HEAD (8537dee). Click for more details.

HEAD has 22 uploads less than BASE
Flag BASE (60f2d2c) HEAD (8537dee)
24 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
- Coverage   74.70%   64.92%   -9.78%     
==========================================
  Files         242      240       -2     
  Lines       25862    25591     -271     
  Branches     4661     4594      -67     
==========================================
- Hits        19319    16614    -2705     
- Misses       5674     8156    +2482     
+ Partials      869      821      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby merged commit cca5210 into main Jul 9, 2024
29 of 41 checks passed
@justinchuby justinchuby deleted the justinchu/type-as branch July 9, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at lgtm Reviewers can merge when they approve topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants