Temporary solution for demo | chore(torchlib) #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #930 +/- ##
==========================================
- Coverage 76.87% 76.78% -0.10%
==========================================
Files 112 112
Lines 13736 13760 +24
Branches 1407 1408 +1
==========================================
+ Hits 10560 10566 +6
- Misses 2824 2842 +18
Partials 352 352
|
justinchuby
approved these changes
Jul 28, 2023
|
Merging for demo |
justinchuby
reviewed
Jul 28, 2023
justinchuby
reviewed
Jul 28, 2023
justinchuby
changed the title
justinchuby
added
the
topic: torch_lib
BowenBao
reviewed
Jul 28, 2023
|
@justinchuby, I disable that test in CI because CI is not ready. That new line is always run by other to_model_proto calls, so it should be fine. |
justinchuby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack for #493 for demo. Will need a more proper solution.