-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate NeuTrader to Qlib RL #1169
Conversation
Please merge the main branch and solve the conflicts. |
You can merge master to update the latest handler by fyc #1212 |
@@ -0,0 +1,2 @@ | |||
# Copyright (c) Microsoft Corporation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think from_neutrader
should be renamed.
I remember I raised a similar comment once, but somehow I couldn't find it any more...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR really still a draft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor comments. The rest part looks good to me.
|
||
Parameters | ||
---------- | ||
action (float): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
Parameters | ||
---------- | ||
order (Order): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can omit the type in docstring if type annotation is available.
* Refine previous version RL codes * Polish utils/__init__.py * Draft * Use | instead of Union * Simulator & action interpreter * Test passed * Migrate to SAOEState & new qlib interpreter * Black format * . Revert file_storage change * Refactor file structure & renaming functions * Enrich test cases * Add QlibIntradayBacktestData * Test interpreter * Black format * . . . * Rename receive_execute_result() * Use indicator to simplify state update * Format code * Modify data path * Adjust file structure * Minor change * Add copyright message * Format code * Rename util functions * Add CI * Pylint issue * Remove useless code to pass pylint * Pass mypy * Mypy issue * mypy issue * mypy issue * Revert "mypy issue" This reverts commit 8eb1b01. * mypy issue * mypy issue * Fix the numpy version incompatible bug * Fix a minor typing issue * Try to skip python 3.7 test for qlib simulator * Resolve PR comments by Yuge; solve several CI issues. * Black issue * Fix a low-level type error * Change data name * Resolve PR comments. Leave TODOs in the code base. Co-authored-by: Young <[email protected]>
Description
QlibSimulator
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.Screenshots of Test Results (if appropriate):
Types of changes